[BugFix] to_observation_norm now works with keys which are not strings #2045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2045
Note: Links to docs will display an error until the docs builds have been completed. ❌ 14 New Failures, 1 Unrelated FailureAs of commit 74071c4 with merge base ee8cafb ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
vmoens
changed the title
added 2 commits
April 19, 2024 10:50
# Conflicts: # torchrl/envs/transforms/transforms.py
Collaborator
|
I took the liberty of making a couple of edits. I paved the way for this with some commented changes, I will leave them here as a suggestion for anyone who'd be interested in implementing that. The next step is to store the tracking values in the tensordict rather than in the transform (we could add an underscore before the key string to indicate that these values are private and should not be returned by collectors for instance) |
added 2 commits
April 19, 2024 14:36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the _key_str method in the to_observation_norm method of VecNorm. A call to to_observation_norm would have previously given an error, since in the update method, a call is made to _key_str to store the sum argument etc. However, this call was not made in to_observation_norm, resulting in the key not being able to be found in _td.
Are there any tests that need to be updated to reflect this?
I've raised this in issue #2036.
Types of changes
What types of changes does your code introduce? Remove all that do not apply:
Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!